1
0
Fork 0
forked from forks/qmk_firmware
qmk_firmware/users/drashna/keyrecords
Jeff Epler 9632360caa
Use a macro to compute the size of arrays at compile time (#18044)
* Add ARRAY_SIZE and CEILING utility macros

* Apply a coccinelle patch to use ARRAY_SIZE

* fix up some straggling items

* Fix 'make test:secure'

* Enhance ARRAY_SIZE macro to reject acting on pointers

The previous definition would not produce a diagnostic for
```
int *p;
size_t num_elem = ARRAY_SIZE(p)
```
but the new one will.

* explicitly get definition of ARRAY_SIZE

* Convert to ARRAY_SIZE when const is involved

The following spatch finds additional instances where the array is
const and the division is by the size of the type, not the size of
the first element:
```
@ rule5a using "empty.iso" @
type T;
const T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)

@ rule6a using "empty.iso" @
type T;
const T[] E;
@@

- sizeof(E)/sizeof(T)
+ ARRAY_SIZE(E)
```

* New instances of ARRAY_SIZE added since initial spatch run

* Use `ARRAY_SIZE` in docs (found by grep)

* Manually use ARRAY_SIZE

hs_set is expected to be the same size as uint16_t, though it's made
of two 8-bit integers

* Just like char, sizeof(uint8_t) is guaranteed to be 1

This is at least true on any plausible system where qmk is actually used.

Per my understanding it's universally true, assuming that uint8_t exists:
https://stackoverflow.com/questions/48655310/can-i-assume-that-sizeofuint8-t-1

* Run qmk-format on core C files touched in this branch

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
2022-08-30 10:20:04 +02:00
..
autocorrection [Keymap] Drashna keymap updates for 0.18.0 (#18184) 2022-08-28 12:55:19 -07:00
capwords.md [Keymap] Reorganization, cleanup and readmes for drashna code (#15617) 2021-12-29 20:17:34 -08:00
keycodes.md [Keymap] Drashna update for post Q2 merge (#17241) 2022-05-30 22:02:55 -07:00
process_records.c [Keymap] Drashna keymap updates for 0.18.0 (#18184) 2022-08-28 12:55:19 -07:00
process_records.h [Keymap] Updates to drashna Keymaps and Userspace (#17543) 2022-07-02 19:55:46 -07:00
readme.md [Keymap] Reorganization, cleanup and readmes for drashna code (#15617) 2021-12-29 20:17:34 -08:00
secrets.md [Keymap] Drashna update for post Q2 merge (#17241) 2022-05-30 22:02:55 -07:00
tap_dance.md Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00
tap_dances.c Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00
tap_dances.h [Keymap] Updates to drashna Keymaps and Userspace (#17543) 2022-07-02 19:55:46 -07:00
tapping.c [Keymap] Drashna keymap updates for 0.18.0 (#18184) 2022-08-28 12:55:19 -07:00
unicode.c Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00
unicode.h [Keymap] Updates to drashna Keymaps and Userspace (#17543) 2022-07-02 19:55:46 -07:00
unicode.md [Keymap] Reorganization, cleanup and readmes for drashna code (#15617) 2021-12-29 20:17:34 -08:00
wrappers.h [Keymap] Reorganization, cleanup and readmes for drashna code (#15617) 2021-12-29 20:17:34 -08:00
wrappers.md [Keymap] Reorganization, cleanup and readmes for drashna code (#15617) 2021-12-29 20:17:34 -08:00