varl/qmk_firmware
1
0
Fork 0
forked from forks/qmk_firmware
Code Pull requests Activity

Fix submodule check for qmk setup (#11379)

Browse source 
The initialization of the submodules would succeed, but the result of the subsequent
check_submodules() run wasn't checked correctly.

Co-authored-by: Stefan Schulze <stefan.andre.schulze@posteo.de>
This commit is contained in:
Stefan Schulze 2021-02-16 18:45:05 +01:00 committed by GitHub
parent 95304f269b
commit 4a10dfb54d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/python/qmk/cli/doctor.py
View file

@ -107,9 +107,9 @@ def doctor(cli):
submodules.update() submodules.update()
sub_ok = check_submodules() sub_ok = check_submodules()
if CheckStatus.ERROR in sub_ok: if sub_ok == CheckStatus.ERROR:
status = CheckStatus.ERROR status = CheckStatus.ERROR
elif CheckStatus.WARNING in sub_ok and status == CheckStatus.OK: elif sub_ok == CheckStatus.WARNING and status == CheckStatus.OK:
status = CheckStatus.WARNING status = CheckStatus.WARNING
# Report a summary of our findings to the user # Report a summary of our findings to the user