varl/qmk_firmware
1
0
Fork 0
forked from forks/qmk_firmware
Code Pull requests Activity

Reject duplicate matrix locations in LAYOUT macros (#23273)

Browse source
This commit is contained in:
Joel Challis 2024-03-13 23:04:49 +00:00 committed by GitHub
parent 6c95ec0c09
commit af1ac6b1bd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/python/qmk/info.py
View file

@ -107,6 +107,15 @@ def _validate_layouts(keyboard, info_data): # noqa C901
if col >= col_num: if col >= col_num:
_log_error(info_data, f'{layout_name}: Matrix column for key {index} ({key_name}) is {col} but must be less than {col_num}') _log_error(info_data, f'{layout_name}: Matrix column for key {index} ({key_name}) is {col} but must be less than {col_num}')
# Reject duplicate matrix locations
for layout_name, layout_data in layouts.items():
seen = set()
for index, key_data in enumerate(layout_data['layout']):
key = f"{key_data['matrix']}"
if key in seen:
_log_error(info_data, f'{layout_name}: Matrix location for key {index} is not unique {key_data}')
seen.add(key)
# Warn if physical positions are offset (at least one key should be at x=0, and at least one key at y=0) # Warn if physical positions are offset (at least one key should be at x=0, and at least one key at y=0)
for layout_name, layout_data in layouts.items(): for layout_name, layout_data in layouts.items():
offset_x = min([_get_key_left_position(k) for k in layout_data['layout']]) offset_x = min([_get_key_left_position(k) for k in layout_data['layout']])