varl/qmk_firmware
1
0
Fork 0
forked from forks/qmk_firmware
Code Pull requests Activity

Fixed usb read loops not reading until timeout (#16827)

Browse source 
* the size variable was redeclared (hiding the variable of the outside scope) and therefore the while check was always false, so the compiler just removed the do while loop, but it would be better to read all data and only exit the task, after this is done
This commit is contained in:
Sascha 2022-04-10 00:27:02 +02:00 committed by GitHub
parent 4ce0203208
commit bf67abb046
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tmk_core/protocol/chibios/usb_main.c
View file

@ -1074,7 +1074,7 @@ void console_task(void) {
uint8_t buffer[CONSOLE_EPSIZE]; uint8_t buffer[CONSOLE_EPSIZE];
size_t size = 0; size_t size = 0;
do { do {
size_t size = chnReadTimeout(&drivers.console_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE); size = chnReadTimeout(&drivers.console_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE);
if (size > 0) { if (size > 0) {
console_receive(buffer, size); console_receive(buffer, size);
} }
@ -1102,7 +1102,7 @@ void raw_hid_task(void) {
uint8_t buffer[RAW_EPSIZE]; uint8_t buffer[RAW_EPSIZE];
size_t size = 0; size_t size = 0;
do { do {
size_t size = chnReadTimeout(&drivers.raw_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE); size = chnReadTimeout(&drivers.raw_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE);
if (size > 0) { if (size > 0) {
raw_hid_receive(buffer, size); raw_hid_receive(buffer, size);
} }
@ -1125,7 +1125,7 @@ void midi_ep_task(void) {
uint8_t buffer[MIDI_STREAM_EPSIZE]; uint8_t buffer[MIDI_STREAM_EPSIZE];
size_t size = 0; size_t size = 0;
do { do {
size_t size = chnReadTimeout(&drivers.midi_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE); size = chnReadTimeout(&drivers.midi_driver.driver, buffer, sizeof(buffer), TIME_IMMEDIATE);
if (size > 0) { if (size > 0) {
MIDI_EventPacket_t event; MIDI_EventPacket_t event;
recv_midi_packet(&event); recv_midi_packet(&event);