varl/qmk_firmware
1
0
Fork 0
forked from forks/qmk_firmware
Code Pull requests Activity
27163 commits 2 branches 1545 tags 870 MiB
Commit graph

206 commits

Author SHA1 Message Date
Ryan 47966dc2a6
Migrate rgblight.pin and RGB_DI_PIN to ws2812.pin (#20303) 2023-04-06 18:00:54 +10:00
Ryan 8bb4cba7b0
Move TKL layouts to data driven (#20337) 2023-04-05 15:53:45 +10:00
Ryan 09a2b70a66
Move Alice and Ergodox layouts to data driven (#20340) 2023-04-05 15:50:56 +10:00
Ryan 647c2835e6
WS2812 driver improvements (#20262) 2023-03-30 12:21:02 +11:00
Ryan 36ce81df59
Move WS2812_DRIVER to data driven (#20248) 2023-03-26 18:22:12 +11:00
Ryan 02ccc50e60
Remove more empty headers (#20155) 2023-03-17 14:02:04 +11:00
Ryan 9dbee3e23d
Remove useless "ifdef KEYBOARD_*" (#20078) 
Co-authored-by: Nick Brassel <nick@tzarc.org>
 2023-03-16 20:18:33 +11:00
Ryan dd086a51d8
Move matrix config to info.json, part 2 (#19987) 2023-03-10 22:16:56 +11:00
Ryan ea77246865
Migrate some more layouts to data driven (#19889) 2023-02-23 09:32:18 +11:00
Nick Brassel 7f805cc779
VIA Protocol 12 + fixes (#19916) 
Co-authored-by: Wilba <wilba@wilba.tech>
Co-authored-by: zvecr <git@zvecr.com>
 2023-02-23 09:19:00 +11:00
Ryan 2da0827d4f
Remove matrix size defines (#19581) 2023-02-17 16:08:25 +11:00
Ryan f4ba17c4a0
Move LED indicator config to data driven (#19800) 2023-02-17 13:14:29 +11:00
QMK Bot 79b364d289 Merge remote-tracking branch 'origin/master' into develop 2023-02-10 18:06:46 +00:00
Xelus22 d0702b519d
[Keyboard] Update Pachi RGB Rev2 VIA custom indicators (#19788) 2023-02-10 10:06:37 -08:00
Ryan f9aeea64c1
Migrate MCU and BOOTLOADER to data-driven (#19529) 2023-02-08 18:41:46 +11:00
Ryan ebb512db82
Debounce defines cleanup (#19742) 
* Clean up `DEBOUNCE` in config.h, 0-9

* Clean up `DEBOUNCE` in config.h, A

* Clean up `DEBOUNCE` in config.h, B

* Clean up `DEBOUNCE` in config.h, C

* Clean up `DEBOUNCE` in config.h, D

* Clean up `DEBOUNCE` in config.h, E

* Clean up `DEBOUNCE` in config.h, F

* Clean up `DEBOUNCE` in config.h, G

* Clean up `DEBOUNCE` in config.h, H

* Clean up `DEBOUNCE` in config.h, handwired

* Clean up `DEBOUNCE` in config.h, I

* Clean up `DEBOUNCE` in config.h, J

* Clean up `DEBOUNCE` in config.h, K

* Clean up `DEBOUNCE` in config.h, L

* Clean up `DEBOUNCE` in config.h, M

* Clean up `DEBOUNCE` in config.h, N

* Clean up `DEBOUNCE` in config.h, O

* Clean up `DEBOUNCE` in config.h, P

* Clean up `DEBOUNCE` in config.h, Q

* Clean up `DEBOUNCE` in config.h, R

* Clean up `DEBOUNCE` in config.h, S

* Clean up `DEBOUNCE` in config.h, T

* Clean up `DEBOUNCE` in config.h, U

* Clean up `DEBOUNCE` in config.h, V

* Clean up `DEBOUNCE` in config.h, W

* Clean up `DEBOUNCE` in config.h, X

* Clean up `DEBOUNCE` in config.h, Y

* Clean up `DEBOUNCE` in config.h, Z

* Remove default debounce from info.json

* Migrate non-default debounce to info.json
 2023-02-03 19:19:58 +00:00
Ryan f20a05440e
Remove unused MATRIX_HAS_GHOST from config.h (#19726) 2023-02-03 00:04:10 +00:00
Nick Brassel f6dd8dea2e
Remove usages of config_common.h from config.h files. (#19714) 2023-01-31 06:03:30 +11:00
Ryan 56555c61e1
Migrate LAYOUTS to data driven (#19541) 
* Migrate `LAYOUTS` to data driven, 0-9

* Migrate `LAYOUTS` to data driven, A

* Migrate `LAYOUTS` to data driven, B

* Migrate `LAYOUTS` to data driven, C

* Migrate `LAYOUTS` to data driven, D

* Migrate `LAYOUTS` to data driven, E

* Migrate `LAYOUTS` to data driven, F

* Migrate `LAYOUTS` to data driven, G

* Migrate `LAYOUTS` to data driven, H

* Migrate `LAYOUTS` to data driven, handwired

* Migrate `LAYOUTS` to data driven, I

* Migrate `LAYOUTS` to data driven, J

* Migrate `LAYOUTS` to data driven, K

* Migrate `LAYOUTS` to data driven, L

* Migrate `LAYOUTS` to data driven, M

* Migrate `LAYOUTS` to data driven, N

* Migrate `LAYOUTS` to data driven, O

* Migrate `LAYOUTS` to data driven, P

* Migrate `LAYOUTS` to data driven, Q

* Migrate `LAYOUTS` to data driven, R

* Migrate `LAYOUTS` to data driven, S

* Migrate `LAYOUTS` to data driven, T

* Migrate `LAYOUTS` to data driven, U

* Migrate `LAYOUTS` to data driven, V

* Migrate `LAYOUTS` to data driven, W

* Migrate `LAYOUTS` to data driven, X

* Migrate `LAYOUTS` to data driven, Y

* Migrate `LAYOUTS` to data driven, Z
 2023-01-10 02:48:20 +00:00
Ryan 801d2ff940
Remove useless line continuations (#19399) 2022-12-30 11:48:05 +11:00
Xelus22 0b1d5497fc
[Keyboard] Refactor xs60 with soldered and hotswap version (#19049) 
Co-authored-by: Drashna Jaelre <drashna@live.com>
 2022-12-06 00:32:25 -08:00
Ryan e12ca14af8
Change RGB_MATRIX_STARTUP_* defines to RGB_MATRIX_DEFAULT_* (#19079) 2022-11-27 04:18:24 +11:00
Joel Challis fe577daf96
Remove .noci functionality (#19122) 2022-11-21 02:03:38 +00:00
QMK Bot deca2069dc Merge remote-tracking branch 'origin/master' into develop 2022-11-20 07:32:08 +00:00
Xelus22 e172148e46
[Keyboard] Add XS108 (#19112) 
Co-authored-by: Ryan <fauxpark@gmail.com>
 2022-11-19 23:31:02 -08:00
Ryan 20ed138236
LED config fixes (#18973) 2022-11-11 12:15:19 +11:00
Wilba bc6f8dc8b0
VIA V3 - The Custom UI Update (#18222) 2022-11-10 07:46:44 +11:00
Ryan db2aa039f1
Remove more UNUSED_PINS defines (#18940) 2022-11-03 17:42:19 +00:00
Ryan c347e732be
Remove legacy EEPROM clear keycodes (#18782) 
* `EEP_RST` -> `EE_CLR`, default-ish keymaps

* `EEP_RST` -> `EE_CLR`, user keymaps

* `EEP_RST` -> `EE_CLR`, community layouts

* `EEP_RST` -> `EE_CLR`, userspace

* `EEP_RST` -> `EE_CLR`, docs & core
 2022-10-20 12:20:07 +01:00
Ryan 5e4b076af3
Remove legacy keycodes, part 5 (#18710) 
* `KC_SLCK` -> `KC_SCRL`
* `KC_NLCK` -> `KC_NUM`
 2022-10-15 22:29:43 +01:00
Drashna Jaelre f0da486fab
Remove RGBLIGHT_ANIMATION and clean up effect defines for R-Z (#18728) 2022-10-15 09:55:53 -07:00
QMK Bot 7c0116a3ec Merge remote-tracking branch 'origin/master' into develop 2022-10-15 16:37:02 +00:00
James Young 1e726a13d8
Xelus RS60 Layout Refactor (#18708) 
* add matrix diagrams

* add LAYOUT_60_ansi

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_tsangan_hhkb

* enable Community Layout support

* enable Community Layout support, phase 2

Remove the `LAYOUTS` rules from the `rules.mk` files, now that the data is in `info.json`.
 2022-10-15 09:36:20 -07:00
Drashna Jaelre 64b1ed4550
Fix Per Key LED Indicator Callbacks (#18450) 
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
 2022-10-04 15:24:22 -07:00
Ryan 36c410592d
Change DRIVER_LED_COUNT to {LED,RGB}_MATRIX_LED_COUNT (#18399) 2022-09-23 22:46:23 +10:00
Xelus22 489b287e1f
[Keyboard] RS60 Rev2 change to eeprom emulation (#18201) 
by xelus
 2022-09-03 16:27:00 +01:00
Xelus22 f3d52d8fe8
[Keyboard] Kangaroo Rev2 (#18199) 2022-08-29 20:03:30 -07:00
QMK Bot e36ae90a65 Merge remote-tracking branch 'origin/master' into develop 2022-08-21 22:09:30 +00:00
Ryan b0eda7701a
Move keyboard USB IDs and strings to data driven, pass 3 (#18111) 2022-08-21 23:08:50 +01:00
fauxpark 61689ae609 Merge remote-tracking branch 'upstream/master' into develop 2022-08-20 10:55:40 +10:00
Ryan 201f1a8f47
Move keyboard USB IDs and strings to data driven, pass 2: S-Y (#18093) 2022-08-20 01:48:38 +01:00
QMK Bot 9f0925fb18 Merge remote-tracking branch 'origin/master' into develop 2022-08-16 14:29:11 +00:00
Joel Challis 164faf0a5c
Use correct board file in xelus/valor_frl_tkl/rev2_0 (#18071) 2022-08-16 15:28:22 +01:00
QMK Bot 904df296b0 Merge remote-tracking branch 'origin/master' into develop 2022-08-15 17:55:58 +00:00
Joel Challis e44b6242b7
Migrate more F4x1 board files (#18054) 2022-08-15 18:55:21 +01:00
Drashna Jael're ac31e42974
Merge remote-tracking branch 'origin/master' into develop 2022-08-14 01:54:23 -07:00
Xelus22 4195eb8fe1
[Keyboard] Add Valor FRL TKL rev2.0 and 2.1 (#17992) 
* add valor frl tkl rev2 by xelus22
 2022-08-14 08:17:11 +01:00
QMK Bot 93914142a3 Merge remote-tracking branch 'origin/master' into develop 2022-08-07 01:24:34 +00:00
Joel Challis c6ad38e79f
RESET -> QK_BOOT default keymaps (#17939) 2022-08-07 02:23:58 +01:00
Nick Brassel 154d35ac14
Remove UNUSED_PINS (#17931) 2022-08-06 23:23:35 +10:00
Stefan Kerkmann f27b617f36
[Core] Process all changed keys in one scan loop, deprecate QMK_KEYS_PER_SCAN (#15292) 2022-08-06 20:51:13 +10:00
Ryan 0e3cc6af12
Move keyboard USB IDs and strings to data driven: X (#17925) 2022-08-06 18:45:43 +10:00
Xelus22 f8a56cd638
[Keyboard] RS108 Addition (#16989) 2022-07-02 21:42:48 +10:00
QMK Bot f5e1d2f76a Merge remote-tracking branch 'origin/master' into develop 2022-05-23 06:22:01 +00:00
Xelus22 00fcfd9181
[Keyboard][Fix] Change default keymap tilde to grv (#17185) 2022-05-22 23:21:23 -07:00
QMK Bot cc8c539d00 Merge remote-tracking branch 'origin/master' into develop 2022-05-17 12:01:31 +00:00
Xelus22 654baebb2c
fix non-working builds (#17123) 2022-05-17 13:00:26 +01:00
Joel Challis b7771ec25b
RESET -> QK_BOOT default keymaps (#17037) 2022-05-15 20:26:27 +01:00
QMK Bot 7598f1f3af Merge remote-tracking branch 'origin/master' into develop 2022-05-06 06:16:19 +00:00
Xelus22 49267b135b
[Bug] Fix RS60 Rev2 I2C (#17015) 2022-05-06 16:15:49 +10:00
QMK Bot 034854ae39 Merge remote-tracking branch 'origin/master' into develop 2022-05-05 08:09:13 +00:00
Xelus22 3fbf9dc290
[Keyboard] RS60 Rev2 Addition (#16988) 2022-05-05 01:08:35 -07:00
QMK Bot 5f817a1d7f Merge remote-tracking branch 'origin/master' into develop 2022-03-15 13:57:46 +00:00
Ryan 764dc18a81
Remove NO_ACTION_MACRO and NO_ACTION_FUNCTION from keyboard config.h (#16655) 2022-03-15 13:56:58 +00:00
Ryan 7d41639d54
Map data driven DESCRIPTION as string literal (#16523) 2022-03-05 00:20:34 +00:00
Joel Challis 83a32b2574
Remove 1k USB_POLLING_INTERVAL_MS config from keyboards and default-ish keymaps (#16448) 
* Remove 1k USB_POLLING_INTERVAL_MS config from keyboard level

* Remove 1k USB_POLLING_INTERVAL_MS config from default|via keymaps
 2022-02-26 03:20:57 +00:00
Xelus22 8d5375d08b
[Bug] fix Pachi RGB Rev2 RGB positioning (#16182) 2022-02-04 13:22:53 -08:00
James Young aee6ff5c08
Xelus Pachi: add info.json files; rename layout macros (#16123) 
* xelus/pachi/mini_32u4: add info.json

* xelus/pachi/rev1: add info.json

* xelus/pachi/rgb/rev1: add info.json

* xelus/pachi/rgb/rev2: add info.json

* rename LAYOUT_ansi_tsangan to LAYOUT_tkl_ansi_tsangan

Rename `LAYOUT_ansi_tsangan` to `LAYOUT_tkl_ansi_tsangan` for the Pachi RGB revisions.
 2022-01-29 23:11:50 -08:00
Albert Y 3d63c814d3
Correct matrix effect name (#15816) 2022-01-11 09:57:25 -08:00
Xelus22 58fbafeeab
[Keyboard] Add La+ (#15460) 2021-12-14 10:53:36 -08:00
Ryan f718a10889
Fix up build options comments (#15463) 2021-12-12 18:05:37 -08:00
Xelus22 ae34dde677
[Keyboard] Add XS60 (#15248) 
Co-authored-by: Ryan <fauxpark@gmail.com>
 2021-12-11 10:39:34 -08:00
Xelus22 4ab9fac6a6
[Keyboard] Pachi RGB update (#15440) 
* update

* update rev1 description
 2021-12-09 12:12:05 +00:00
Ryan a8d440e4e0
Tidy up NKRO_ENABLE rules (#15382) 2021-12-09 16:05:44 +11:00
Ryan c12b997679
Tidy up SLEEP_LED_ENABLE rules (#15362) 2021-12-01 21:13:00 +11:00
Xelus22 421e69cae4
[Keyboard] kangaroo improvements (#15350) 2021-11-30 09:50:18 -08:00
Xelus22 eaf17b3260
[Bug] Xelus Keyboards 400kHz i2c fix (#15315) 
* 400khz fix

* fix valor rev2 timing

* keep consistent
 2021-11-28 12:12:04 +11:00
Joel Challis 282e916d86
Remove use of __flash due to LTO issues (#15268) 2021-11-24 18:38:49 +11:00
Drashna Jael're adb6feb9f0
Merge remote-tracking branch 'origin/master' into develop 2021-11-16 11:33:17 -08:00
Xelus22 053a970cba
[Keyboard] Add Pachi RGB Rev 2 (#15141) 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
 2021-11-16 11:16:06 -08:00
Drashna Jaelre 160b0558f5
Require explicit enabling of RGB Matrix modes (#15018) 2021-11-15 10:41:04 -08:00
James Young 84ea77ead6
Remove BOOTMAGIC_ENABLE = lite option (#15002) 
* remove BOOTMAGIC_ENABLE=lite setting

* change keyboard BOOTMAGIC_ENABLE rules

Edits keyboard-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

* change keyboard BOOTMAGIC_ENABLE inline comments

Edits keyboard-level BOOTMAGIC_ENABLE inline comments to "Enable Bootmagic Lite".

* change keymap BOOTMAGIC_ENABLE rules

Edits keymap-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

* change keymap BOOTMAGIC_ENABLE inline comments

Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".

* change layout/user BOOTMAGIC_ENABLE rules/comments

Edits instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".

* update non-rules.mk BOOTMAGIC_ENABLE references in keyboards/

* remove docs references to Full Bootmagic

* convert data-driven Bootmagic Lite instances

* remove Bootmagic Lite bodge from data-driven generation

* Merge remote-tracking branch 'upstream/develop' into rm/bootmagic-full_q4a

* update docs/ja/config_options.md per mtei

* update docs/faq_misc.md per mtei

Remove remaining Full Bootmagic reference.
 2021-11-05 08:18:09 +11:00
QMK Bot e0793ea31d Merge remote-tracking branch 'origin/master' into develop 2021-11-04 07:17:12 +00:00
James Young aaf4b348f0
Xelus Dawn60 Layout Macro Additions (#15049) 
* add matrix diagrams to keyboard header files

* rename LAYOUT_60_all to LAYOUT_all

* add LAYOUT_60_ansi_arrow

* add LAYOUT_60_tsangan_hhkb
 2021-11-04 00:16:35 -07:00
Ryan b487e10753
Clean up LED/RGB Matrix driver config (#14760) 2021-10-10 16:57:49 -07:00
QMK Bot 948023c70a Merge remote-tracking branch 'origin/master' into develop 2021-10-08 21:23:35 +00:00
Drashna Jaelre f90d8b35f2
[Keyboard] Fix IS31FL3741 driver flushin for Xelus pachi rgb (#14755) 2021-10-08 22:23:03 +01:00
James Young 922c8071e4
Merge remote-tracking branch 'upstream/master' into develop 2021-09-29 23:23:10 -07:00
Ryan 36bc3c867e
Remove redundant UNICODE_ENABLE = no in keyboard-level rules.mk (#14633) 2021-09-30 08:14:21 +10:00
fauxpark 94572d74b5 Merge remote-tracking branch 'upstream/master' into develop 2021-09-21 20:19:07 +10:00
Ryan 6b74e48f81
Remove audio pin references in rules.mk (#14532) 2021-09-21 20:04:03 +10:00
fauxpark c38a730805 Merge remote-tracking branch 'upstream/master' into develop 2021-09-20 16:58:29 +10:00
Ryan 574b6734af
Remove backlight pin references in rules.mk (#14513) 2021-09-20 16:51:00 +10:00
Joel Challis 0fa217a5b7
Align ChibiOS I2C defs with other drivers (#14399) 
* Align ChibiOS I2C defs with other drivers

* Update keyboards/xelus/valor_frl_tkl/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
 2021-09-12 15:41:33 +01:00
Ryan 5af1799735
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (#14379) 2021-09-12 15:27:29 +10:00
Ryan 4791cfae1a
Remove width, height and key_count from info.json (#14274) 2021-09-12 14:04:56 +10:00
Xelus22 759d1927f0
[Keyboard] Add RS60 (#14073) 
* initial rs60

* update

* remove

* Include rs60.h

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* List form readme.

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* change layout name

Co-authored-by: Joel Challis <git@zvecr.com>

* add layout

Co-authored-by: Joel Challis <git@zvecr.com>

* add license

Co-authored-by: Joel Challis <git@zvecr.com>

* 2021 update

Co-authored-by: Joel Challis <git@zvecr.com>

* add license

Co-authored-by: Joel Challis <git@zvecr.com>

* sigprof suggested changes

* Remove redundant define

Co-authored-by: Ryan <fauxpark@gmail.com>

* Fixup readme

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

* Update keyboards/xelus/rs60/info.json

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
 2021-09-10 20:14:39 +01:00
Ryan 7eea780a7d
Remove bootloader listings from rules.mk (#14330) 2021-09-10 13:35:46 +10:00
James Young 4b453dca92
Remove MIDI Configuration boilerplate (#11151) 
* remove keyboard-level instances of `MIDI_ENABLE = no`

Command:

```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e  '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```

Co-Authored-By: Nick Brassel <nick@tzarc.org>

* fix case-sensitivity issues on MIDI_ENABLE

Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.

Command:

```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```

* replace `# MIDI controls` with `# MIDI support`

Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.

Command:

```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```

* align inline comments

Aligns the inline comments to the length used by the QMK AVR rules.mk template.

Command:

```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes           # MIDI support;g'  {} +
```

* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files

Commands:

```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```

* remove MIDI configuration boilerplate from keyboard config.h files

Co-authored-by: Nick Brassel <nick@tzarc.org>
 2021-08-16 06:51:13 +10:00
Drashna Jaelre 6fb9842936
Clean up remaining RGB_DISABLE_WHEN_USB_SUSPENDED defines Part 2 (#13912) 2021-08-07 15:18:06 +01:00