1
0
Fork 0
forked from forks/qmk_firmware
Commit graph

5 commits

Author SHA1 Message Date
Ryan e2630f9b40
Fix some invalid layout macros (#20256) 2023-03-29 15:51:22 +11:00
Ryan 36c410592d
Change DRIVER_LED_COUNT to {LED,RGB}_MATRIX_LED_COUNT (#18399) 2022-09-23 22:46:23 +10:00
Jeff Epler 9632360caa
Use a macro to compute the size of arrays at compile time (#18044)
* Add ARRAY_SIZE and CEILING utility macros

* Apply a coccinelle patch to use ARRAY_SIZE

* fix up some straggling items

* Fix 'make test:secure'

* Enhance ARRAY_SIZE macro to reject acting on pointers

The previous definition would not produce a diagnostic for
```
int *p;
size_t num_elem = ARRAY_SIZE(p)
```
but the new one will.

* explicitly get definition of ARRAY_SIZE

* Convert to ARRAY_SIZE when const is involved

The following spatch finds additional instances where the array is
const and the division is by the size of the type, not the size of
the first element:
```
@ rule5a using "empty.iso" @
type T;
const T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)

@ rule6a using "empty.iso" @
type T;
const T[] E;
@@

- sizeof(E)/sizeof(T)
+ ARRAY_SIZE(E)
```

* New instances of ARRAY_SIZE added since initial spatch run

* Use `ARRAY_SIZE` in docs (found by grep)

* Manually use ARRAY_SIZE

hs_set is expected to be the same size as uint16_t, though it's made
of two 8-bit integers

* Just like char, sizeof(uint8_t) is guaranteed to be 1

This is at least true on any plausible system where qmk is actually used.

Per my understanding it's universally true, assuming that uint8_t exists:
https://stackoverflow.com/questions/48655310/can-i-assume-that-sizeofuint8-t-1

* Run qmk-format on core C files touched in this branch

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
2022-08-30 10:20:04 +02:00
Drashna Jaelre e755c5fe1f
[Keyboard] Fix RGBKB Pan Rev1 Encoder RGB handling (#13781) 2021-07-31 06:09:47 -07:00
Legonut abf1902ff5
[Keyboard] RGBKB Pan (#9587)
* Add new keyboard Pan

Encoder switches still need work

* New keyboard Pan

Should be complete

* Split MCU selection into 2 revision folders

* [rgbkb/pan] Make requested changes for PR

Additionally, set DEFAULT_FOLDER to rev1, and default rev1
 to atmega32a (as all shipped kits include an atmega32a)

* Apply suggestions from code review

* Fix default keymap typo

* add usb max power define

* Commit suggested changes

* Update keyboards/rgbkb/pan/config.h

* Apply suggestions from code review

Small copyright updates

* Apply suggestions from code review
2020-11-09 22:22:22 -08:00