1
0
Fork 0
forked from forks/qmk_firmware
qmk_firmware/keyboards/acheron
Jeff Epler 9632360caa
Use a macro to compute the size of arrays at compile time (#18044)
* Add ARRAY_SIZE and CEILING utility macros

* Apply a coccinelle patch to use ARRAY_SIZE

* fix up some straggling items

* Fix 'make test:secure'

* Enhance ARRAY_SIZE macro to reject acting on pointers

The previous definition would not produce a diagnostic for
```
int *p;
size_t num_elem = ARRAY_SIZE(p)
```
but the new one will.

* explicitly get definition of ARRAY_SIZE

* Convert to ARRAY_SIZE when const is involved

The following spatch finds additional instances where the array is
const and the division is by the size of the type, not the size of
the first element:
```
@ rule5a using "empty.iso" @
type T;
const T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)

@ rule6a using "empty.iso" @
type T;
const T[] E;
@@

- sizeof(E)/sizeof(T)
+ ARRAY_SIZE(E)
```

* New instances of ARRAY_SIZE added since initial spatch run

* Use `ARRAY_SIZE` in docs (found by grep)

* Manually use ARRAY_SIZE

hs_set is expected to be the same size as uint16_t, though it's made
of two 8-bit integers

* Just like char, sizeof(uint8_t) is guaranteed to be 1

This is at least true on any plausible system where qmk is actually used.

Per my understanding it's universally true, assuming that uint8_t exists:
https://stackoverflow.com/questions/48655310/can-i-assume-that-sizeofuint8-t-1

* Run qmk-format on core C files touched in this branch

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
2022-08-30 10:20:04 +02:00
..
apollo RESET -> QK_BOOT keyboard readme (#18110) 2022-08-20 11:34:17 +01:00
arctic Move keyboard USB IDs and strings to data driven: A (#17781) 2022-07-26 01:52:18 +01:00
athena Migrate more F4x1 board files (#18046) 2022-08-15 00:25:40 +01:00
austin Move keyboard USB IDs and strings to data driven: A (#17781) 2022-07-26 01:52:18 +01:00
elongate Merge remote-tracking branch 'origin/master' into develop 2022-08-20 10:22:48 -07:00
keebspcb Move keyboard USB IDs and strings to data driven: A (#17781) 2022-07-26 01:52:18 +01:00
lasgweloth Move keyboard USB IDs and strings to data driven: A (#17781) 2022-07-26 01:52:18 +01:00
shark Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00