1
0
Fork 0
forked from forks/qmk_firmware
qmk_firmware/keyboards/gboards/georgi
Jeff Epler 9632360caa
Use a macro to compute the size of arrays at compile time (#18044)
* Add ARRAY_SIZE and CEILING utility macros

* Apply a coccinelle patch to use ARRAY_SIZE

* fix up some straggling items

* Fix 'make test:secure'

* Enhance ARRAY_SIZE macro to reject acting on pointers

The previous definition would not produce a diagnostic for
```
int *p;
size_t num_elem = ARRAY_SIZE(p)
```
but the new one will.

* explicitly get definition of ARRAY_SIZE

* Convert to ARRAY_SIZE when const is involved

The following spatch finds additional instances where the array is
const and the division is by the size of the type, not the size of
the first element:
```
@ rule5a using "empty.iso" @
type T;
const T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)

@ rule6a using "empty.iso" @
type T;
const T[] E;
@@

- sizeof(E)/sizeof(T)
+ ARRAY_SIZE(E)
```

* New instances of ARRAY_SIZE added since initial spatch run

* Use `ARRAY_SIZE` in docs (found by grep)

* Manually use ARRAY_SIZE

hs_set is expected to be the same size as uint16_t, though it's made
of two 8-bit integers

* Just like char, sizeof(uint8_t) is guaranteed to be 1

This is at least true on any plausible system where qmk is actually used.

Per my understanding it's universally true, assuming that uint8_t exists:
https://stackoverflow.com/questions/48655310/can-i-assume-that-sizeofuint8-t-1

* Run qmk-format on core C files touched in this branch

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
2022-08-30 10:20:04 +02:00
..
keymaps Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00
config.h Move keyboard USB IDs and strings to data driven: G (#17818) 2022-07-27 20:19:09 +01:00
georgi.c
georgi.h
info.json Move keyboard USB IDs and strings to data driven: G (#17818) 2022-07-27 20:19:09 +01:00
matrix.c Remove matrix_key_count() (#16603) 2022-03-10 12:18:07 +00:00
readme.md
rules.mk gboards/georgi: cleanup & fix (#17753) 2022-07-26 14:01:05 +10:00
sten.c Use a macro to compute the size of arrays at compile time (#18044) 2022-08-30 10:20:04 +02:00
sten.h

Georgi

Georgi

A compact 20% (12x2) Split Keyboard for steno and QWERTY.

More info on qmk.fm

Keyboard Maintainer: Jane Bernhardt
Hardware Supported: Georgi
Hardware Availability: gboards.ca

Firmware building

After cloning the QMK repo and installing dfu-programmer build and flash with. Be sure to reset your keyboard!

make gboards/georgi:default:dfu

To just test your build with the default keymap

make gboards/georgi:default

Build options can be enabled/disabled in keyboards/gboards/georgi/keymaps/default/rules.mk . Copy the default directory and make any changes to your layout, if you think they're worth sharing submit a PR!

Documentation

Is hosted over on docs.gboards.ca. Please take a look at the docs for customizing your firmware!

Space

The stock firmware leaves 7K free for custom entries. For extra space disable mousekeys in your keymaps rules.mk (3K of space) and remove the Gaming layers (1k).

See the build environment setup and the make instructions for more information. Brand new to QMK? Start with our Complete Newbs Guide.

Have an idea? Reach out to me!