varl/qmk_firmware
1
0
Fork 0
forked from forks/qmk_firmware
Code Pull requests Activity
qmk_firmware/keyboards/helix/rev2
History
Takeshi ISHII 4a66bdf294
Fix helix/rev2 not working properly when using split_common. (#16512) 
When helix/rev2 was using split_common, it didn't work properly and I couldn't type on the right hand side.

The cause is that the following code, added in 0.16.0 to `quantum/keyboard.c`, does not include `quantum/split_common/split_util.h` but instead includes `keyboards/helix/rev2/split_util.h`. Therefore, `split_pre_init()/split_post_init()` in `quantum/split_common/split_util.c` was not called.

```c
  #ifdef SPLIT_KEYBOARD
  #    include "split_util.h"
  #endif
```
2022-03-03 20:23:49 +00:00
..
back Initial list of keyboards to exclude from CI (#11213) 2020-12-21 15:38:39 +01:00
custom Fix helix/rev2 not working properly when using split_common. (#16512) 2022-03-03 20:23:49 +00:00
keymaps Change 'helix/rev2:default' setting to use split_common (#16432) 2022-03-02 20:15:10 +09:00
qmk_conf Initial list of keyboards to exclude from CI (#11213) 2020-12-21 15:38:39 +01:00
sc Initial list of keyboards to exclude from CI (#11213) 2020-12-21 15:38:39 +01:00
under Initial list of keyboards to exclude from CI (#11213) 2020-12-21 15:38:39 +01:00
.noci Initial list of keyboards to exclude from CI (#11213) 2020-12-21 15:38:39 +01:00
config.h Change 'helix/rev2:default' setting to use split_common (#16432) 2022-03-02 20:15:10 +09:00
info.json Remove width, height and key_count from info.json (#14274) 2021-09-12 14:04:56 +10:00
local_features.mk Fix helix/rev2 not working properly when using split_common. (#16512) 2022-03-03 20:23:49 +00:00
override_helix_options.mk Fix mistakes in the include path in helix/rev2/local_features.mk. (#16507) 2022-03-03 14:27:21 +00:00
post_config.h [Keyboard] Helix add split common option (#7718) 2020-03-10 01:33:46 -07:00
post_rules.mk [Keyboard] Helix use post_rules.mk (#14216) 2021-08-31 16:58:07 +09:00
readme.md [Keymap] Helix default keymap oled update (#11152) 2020-12-15 20:14:14 +09:00
rev2.c Change 'helix/rev2:default' setting to use split_common (#16432) 2022-03-02 20:15:10 +09:00
rev2.h Change 'helix/rev2:default' setting to use split_common (#16432) 2022-03-02 20:15:10 +09:00
rules.mk Change 'helix/rev2:default' setting to use split_common (#16432) 2022-03-02 20:15:10 +09:00
serial_config_simpleapi.h Change keyboard level include guards to pragma once (#14248) 2021-09-01 19:03:14 +10:00

readme.md

Helix rev2

A compact split ortholinear keyboard.

Make example for this keyboard (after setting up your build environment):

make helix/rev2:default:flash

See the build environment setup and the make instructions for more information. Brand new to QMK? Start with our Complete Newbs Guide.