1
0
Fork 0
forked from forks/qmk_firmware
qmk_firmware/lib/python/qmk
Erovia c89c084146
CLI: More MSYS2 fixes (#8577)
* CLI: More MSYS2 fixes

Now I can fully setup and work with qmk_firmware on an MSYS2
installation without any errors or exceptions.

* Apply suggestions from code review

Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>

* Some improvements

* Remove unnecessary import

* Remove slow, unused code

Getting the version from GIT was slow on both Windows and Docker.
Until we find a better, faster way, this is removed.

* remove unused imports

* Implement @vomindoraan's suggestions

* refine how we pick the shell to use

* Apply @fauxpark's suggestions

fauxpark investigated the topic of shells in MSYS2 a bit and we come to the conclusion that the safest bet was to just use the user's shell.
Anything more just opens up more edge-cases than it solves.

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Use `platform_id` in doctor

This will bring it in line with the new code.

Co-authored-by: skullydazed <skullydazed@users.noreply.github.com>
Co-authored-by: skullY <skullydazed@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
2020-03-29 14:29:44 +02:00
..
cli CLI: More MSYS2 fixes (#8577) 2020-03-29 14:29:44 +02:00
tests CLI: More MSYS2 fixes (#8577) 2020-03-29 14:29:44 +02:00
__init__.py QMK CLI and JSON keymap support (#6176) 2019-07-15 12:14:27 -07:00
commands.py CLI: More MSYS2 fixes (#8577) 2020-03-29 14:29:44 +02:00
constants.py Use pathlib everywhere we can (#7872) 2020-02-17 11:42:11 -08:00
converter.py Add cli convert subcommand, from raw KLE to JSON (#6898) 2019-11-12 20:55:41 -08:00
decorators.py Add decorators for determining keyboard and keymap based on current directory (#8191) 2020-03-13 15:47:04 -07:00
errors.py Small CLI cleanups 2019-11-12 18:41:38 -08:00
keymap.py Use pathlib everywhere we can (#7872) 2020-02-17 11:42:11 -08:00
makefile.py Code cleanup, use pathlib, use pytest keyboard 2020-02-15 15:19:03 -08:00
path.py Add decorators for determining keyboard and keymap based on current directory (#8191) 2020-03-13 15:47:04 -07:00
questions.py Improve the functionality of qmk.questions (#8020) 2020-02-03 09:04:58 -08:00
submodules.py Beef up how qmk doctor works. (#7375) 2020-01-24 20:31:16 +01:00