2015-10-26 21:32:37 +01:00
|
|
|
/*
|
2015-10-26 23:54:46 +01:00
|
|
|
|
|
|
|
|
2015-10-26 21:32:37 +01:00
|
|
|
Copyright 2013 Oleg Kostyuk <cub.uanic@gmail.com>
|
|
|
|
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation, either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* scan matrix
|
|
|
|
*/
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <avr/io.h>
|
2016-07-04 18:13:41 +02:00
|
|
|
#include "wait.h"
|
2015-10-26 21:32:37 +01:00
|
|
|
#include "action_layer.h"
|
|
|
|
#include "print.h"
|
|
|
|
#include "debug.h"
|
|
|
|
#include "util.h"
|
|
|
|
#include "matrix.h"
|
2019-04-03 23:45:55 +02:00
|
|
|
#include "debounce.h"
|
2020-10-01 01:52:47 +02:00
|
|
|
#include "ergodox_ez.h"
|
|
|
|
|
2019-10-10 00:23:57 +02:00
|
|
|
|
2016-07-06 06:24:31 +02:00
|
|
|
/*
|
2019-04-03 23:45:55 +02:00
|
|
|
* This constant define not debouncing time in msecs, assuming eager_pr.
|
2016-07-06 06:24:31 +02:00
|
|
|
*
|
|
|
|
* On Ergodox matrix scan rate is relatively low, because of slow I2C.
|
|
|
|
* Now it's only 317 scans/second, or about 3.15 msec/scan.
|
|
|
|
* According to Cherry specs, debouncing time is 5 msec.
|
|
|
|
*
|
improve ergodox ez performance
With these changes, the ergodox ez goes from 315 scans per second
when no keys are pressed (~3.17ms/scan) to 447 (~2.24ms/scan).
The changes to the pin read are just condensing the logic, and
replacing a lot of conditional operations with a single bitwise
inversion.
The change to row scanning is more significant, and merits
explanation. In general, you can only scan one row of a keyboard
at a time, because if you scan two rows, you no longer know
which row is pulling a given column down. But in the Ergodox
design, this isn't the case; the left hand is controlled by an
I2C-based GPIO expander, and the columns and rows are *completely
separate* electrically from the columns and rows on the right-hand
side.
So simply reading rows in parallel offers two significant
improvements. One is that we no longer need the 30us delay after
each right-hand row, because we're spending more than 30us
communicating with the left hand over i2c. Another is that we're
no longer wastefully sending i2c messages to the left hand
to unselect rows when no rows had actually been selected in the
first place. These delays were, between them, coming out to
nearly 30% of the time spent in each scan.
Signed-off-by: seebs <seebs@seebs.net>
2017-11-18 23:11:26 +01:00
|
|
|
* However, some switches seem to have higher debouncing requirements, or
|
|
|
|
* something else might be wrong. (Also, the scan speed has improved since
|
|
|
|
* that comment was written.)
|
2016-07-06 06:24:31 +02:00
|
|
|
*/
|
|
|
|
|
2015-10-26 21:32:37 +01:00
|
|
|
/* matrix state(1:on, 0:off) */
|
2020-10-01 01:52:47 +02:00
|
|
|
extern matrix_row_t matrix[MATRIX_ROWS]; // debounced values
|
|
|
|
extern matrix_row_t raw_matrix[MATRIX_ROWS]; // raw values
|
2015-10-26 21:32:37 +01:00
|
|
|
|
|
|
|
static matrix_row_t read_cols(uint8_t row);
|
2019-04-03 23:45:55 +02:00
|
|
|
static void init_cols(void);
|
|
|
|
static void unselect_rows(void);
|
|
|
|
static void select_row(uint8_t row);
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2018-06-12 20:27:22 +02:00
|
|
|
static uint8_t mcp23018_reset_loop;
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
void matrix_init_custom(void) {
|
|
|
|
// initialize row and col
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
mcp23018_status = init_mcp23018();
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
unselect_rows();
|
|
|
|
init_cols();
|
Change to per-key eager debouncing for ErgoDox EZ.
Empirically, waiting for N consecutive identical scans as a debouncing
strategy doesn't work very well for the ErgoDox EZ where scans are very
slow compared to most keyboards. Instead, debounce the signals by
eagerly reporting a change as soon as one scan observes it, but then
ignoring further changes from that key for the next N scans.
This is implemented by keeping an extra matrix of uint8 countdowns, such
that only keys whose countdown is currently zero are eligible to change.
When we do observe a change, we bump that key's countdown to DEBOUNCE.
During each scan, every nonzero countdown is decremented.
With this approach to debouncing, much higher debounce constants are
tolerable, because latency does not increase with the constant, and
debounce countdowns on one key do not interfere with events on other
keys. The only negative effect of increasing the constant is that the
minimum duration of a keypress increases. Perhaps I'm just extremely
unlucky w.r.t. key switch quality, but I saw occasional bounces even
with DEBOUNCE=10; with 15, I've seen none so far. That's around 47ms,
which seems like an absolutely insane amount of time for a key to be
bouncy, but at least it works.
2017-04-27 00:29:39 +02:00
|
|
|
}
|
2016-06-18 04:06:58 +02:00
|
|
|
|
2019-04-09 06:52:38 +02:00
|
|
|
// Reads and stores a row, returning
|
|
|
|
// whether a change occurred.
|
|
|
|
static inline bool store_raw_matrix_row(uint8_t index) {
|
2020-10-01 01:52:47 +02:00
|
|
|
matrix_row_t temp = read_cols(index);
|
|
|
|
if (raw_matrix[index] != temp) {
|
|
|
|
raw_matrix[index] = temp;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
2019-04-09 06:52:38 +02:00
|
|
|
}
|
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
bool matrix_scan_custom(matrix_row_t current_matrix[]) {
|
|
|
|
if (mcp23018_status) { // if there was an error
|
|
|
|
if (++mcp23018_reset_loop == 0) {
|
|
|
|
print("trying to reset mcp23018\n");
|
|
|
|
mcp23018_status = init_mcp23018();
|
|
|
|
if (mcp23018_status) {
|
|
|
|
print("left side not responding\n");
|
|
|
|
} else {
|
|
|
|
print("left side attached\n");
|
|
|
|
ergodox_blink_all_leds();
|
2020-01-02 07:42:04 +01:00
|
|
|
#ifdef RGB_MATRIX_ENABLE
|
2020-10-01 01:52:47 +02:00
|
|
|
rgb_matrix_init(); // re-init driver on reconnect
|
2020-01-02 07:42:04 +01:00
|
|
|
#endif
|
2020-10-01 01:52:47 +02:00
|
|
|
}
|
|
|
|
}
|
Change to per-key eager debouncing for ErgoDox EZ.
Empirically, waiting for N consecutive identical scans as a debouncing
strategy doesn't work very well for the ErgoDox EZ where scans are very
slow compared to most keyboards. Instead, debounce the signals by
eagerly reporting a change as soon as one scan observes it, but then
ignoring further changes from that key for the next N scans.
This is implemented by keeping an extra matrix of uint8 countdowns, such
that only keys whose countdown is currently zero are eligible to change.
When we do observe a change, we bump that key's countdown to DEBOUNCE.
During each scan, every nonzero countdown is decremented.
With this approach to debouncing, much higher debounce constants are
tolerable, because latency does not increase with the constant, and
debounce countdowns on one key do not interfere with events on other
keys. The only negative effect of increasing the constant is that the
minimum duration of a keypress increases. Perhaps I'm just extremely
unlucky w.r.t. key switch quality, but I saw occasional bounces even
with DEBOUNCE=10; with 15, I've seen none so far. That's around 47ms,
which seems like an absolutely insane amount of time for a key to be
bouncy, but at least it works.
2017-04-27 00:29:39 +02:00
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2017-10-21 01:53:59 +02:00
|
|
|
#ifdef LEFT_LEDS
|
2020-10-01 01:52:47 +02:00
|
|
|
mcp23018_status = ergodox_left_leds_update();
|
2019-04-03 23:45:55 +02:00
|
|
|
#endif // LEFT_LEDS
|
2020-10-01 01:52:47 +02:00
|
|
|
bool changed = false;
|
|
|
|
for (uint8_t i = 0; i < MATRIX_ROWS_PER_SIDE; i++) {
|
|
|
|
// select rows from left and right hands
|
|
|
|
uint8_t left_index = i;
|
|
|
|
uint8_t right_index = i + MATRIX_ROWS_PER_SIDE;
|
|
|
|
select_row(left_index);
|
|
|
|
select_row(right_index);
|
|
|
|
|
|
|
|
changed |= store_raw_matrix_row(left_index);
|
|
|
|
changed |= store_raw_matrix_row(right_index);
|
|
|
|
|
|
|
|
unselect_rows();
|
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
return changed;
|
2015-10-26 21:32:37 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Column pin configuration
|
|
|
|
*
|
|
|
|
* Teensy
|
|
|
|
* col: 0 1 2 3 4 5
|
2015-10-26 23:54:46 +01:00
|
|
|
* pin: F0 F1 F4 F5 F6 F7
|
2015-10-26 21:32:37 +01:00
|
|
|
*
|
|
|
|
* MCP23018
|
|
|
|
* col: 0 1 2 3 4 5
|
2015-10-26 23:54:46 +01:00
|
|
|
* pin: B5 B4 B3 B2 B1 B0
|
2015-10-26 21:32:37 +01:00
|
|
|
*/
|
2019-04-03 23:45:55 +02:00
|
|
|
static void init_cols(void) {
|
2020-10-01 01:52:47 +02:00
|
|
|
// init on mcp23018
|
|
|
|
// not needed, already done as part of init_mcp23018()
|
|
|
|
|
|
|
|
// init on teensy
|
|
|
|
setPinInputHigh(F0);
|
|
|
|
setPinInputHigh(F1);
|
|
|
|
setPinInputHigh(F4);
|
|
|
|
setPinInputHigh(F5);
|
|
|
|
setPinInputHigh(F6);
|
|
|
|
setPinInputHigh(F7);
|
2015-10-26 21:32:37 +01:00
|
|
|
}
|
|
|
|
|
2019-04-03 23:45:55 +02:00
|
|
|
static matrix_row_t read_cols(uint8_t row) {
|
2020-10-01 01:52:47 +02:00
|
|
|
if (row < 7) {
|
|
|
|
if (mcp23018_status) { // if there was an error
|
|
|
|
return 0;
|
|
|
|
} else {
|
|
|
|
uint8_t data = 0;
|
|
|
|
// reading GPIOB (column port) since in mcp23018's sequential mode
|
|
|
|
// it is addressed directly after writing to GPIOA in select_row()
|
|
|
|
mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT); if (mcp23018_status) goto out;
|
|
|
|
mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT); if (mcp23018_status < 0) goto out;
|
|
|
|
data = ~((uint8_t)mcp23018_status);
|
|
|
|
mcp23018_status = I2C_STATUS_SUCCESS;
|
|
|
|
out:
|
|
|
|
i2c_stop();
|
|
|
|
return data;
|
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
} else {
|
2020-10-01 01:52:47 +02:00
|
|
|
/* read from teensy
|
|
|
|
* bitmask is 0b11110011, but we want those all
|
|
|
|
* in the lower six bits.
|
|
|
|
* we'll return 1s for the top two, but that's harmless.
|
|
|
|
*/
|
2019-04-03 23:45:55 +02:00
|
|
|
|
2020-10-01 01:52:47 +02:00
|
|
|
return ~((PINF & 0x03) | ((PINF & 0xF0) >> 2));
|
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Row pin configuration
|
|
|
|
*
|
|
|
|
* Teensy
|
|
|
|
* row: 7 8 9 10 11 12 13
|
|
|
|
* pin: B0 B1 B2 B3 D2 D3 C6
|
|
|
|
*
|
|
|
|
* MCP23018
|
|
|
|
* row: 0 1 2 3 4 5 6
|
|
|
|
* pin: A0 A1 A2 A3 A4 A5 A6
|
|
|
|
*/
|
2019-04-03 23:45:55 +02:00
|
|
|
static void unselect_rows(void) {
|
2020-10-01 01:52:47 +02:00
|
|
|
// no need to unselect on mcp23018, because the select step sets all
|
|
|
|
// the other row bits high, and it's not changing to a different
|
|
|
|
// direction
|
|
|
|
|
|
|
|
// unselect on teensy
|
|
|
|
setPinInput(B0);
|
|
|
|
setPinInput(B1);
|
|
|
|
setPinInput(B2);
|
|
|
|
setPinInput(B3);
|
|
|
|
setPinInput(D2);
|
|
|
|
setPinInput(D3);
|
|
|
|
setPinInput(C6);
|
2015-10-26 21:32:37 +01:00
|
|
|
}
|
|
|
|
|
2019-04-03 23:45:55 +02:00
|
|
|
static void select_row(uint8_t row) {
|
2020-10-01 01:52:47 +02:00
|
|
|
if (row < 7) {
|
|
|
|
// select on mcp23018
|
|
|
|
if (!mcp23018_status) {
|
|
|
|
// set active row low : 0
|
|
|
|
// set other rows hi-Z : 1
|
|
|
|
mcp23018_status = i2c_start(I2C_ADDR_WRITE, ERGODOX_EZ_I2C_TIMEOUT); if (mcp23018_status) goto out;
|
|
|
|
mcp23018_status = i2c_write(GPIOA, ERGODOX_EZ_I2C_TIMEOUT); if (mcp23018_status) goto out;
|
|
|
|
mcp23018_status = i2c_write(0xFF & ~(1 << row), ERGODOX_EZ_I2C_TIMEOUT); if (mcp23018_status) goto out;
|
|
|
|
out:
|
|
|
|
i2c_stop();
|
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
} else {
|
2020-10-01 01:52:47 +02:00
|
|
|
// select on teensy
|
|
|
|
// Output low(DDR:1, PORT:0) to select
|
|
|
|
switch (row) {
|
|
|
|
case 7:
|
|
|
|
setPinOutput(B0);
|
|
|
|
writePinLow(B0);
|
|
|
|
break;
|
|
|
|
case 8:
|
|
|
|
setPinOutput(B1);
|
|
|
|
writePinLow(B1);
|
|
|
|
break;
|
|
|
|
case 9:
|
|
|
|
setPinOutput(B2);
|
|
|
|
writePinLow(B2);
|
|
|
|
break;
|
|
|
|
case 10:
|
|
|
|
setPinOutput(B3);
|
|
|
|
writePinLow(B3);
|
|
|
|
break;
|
|
|
|
case 11:
|
|
|
|
setPinOutput(D2);
|
|
|
|
writePinLow(D2);
|
|
|
|
break;
|
|
|
|
case 12:
|
|
|
|
setPinOutput(D3);
|
|
|
|
writePinLow(D3);
|
|
|
|
break;
|
|
|
|
case 13:
|
|
|
|
setPinOutput(C6);
|
|
|
|
writePinLow(C6);
|
|
|
|
break;
|
|
|
|
}
|
2015-10-26 21:32:37 +01:00
|
|
|
}
|
|
|
|
}
|